Perl loop problem

[emcron]

Does having an if statement inside a for loop cause problems? My problem is that I have an if statment inside a for loop and for some reason causes my for loop not to increment the value of i.

ie.
for($i=1; $i <= $num_checks; $i++)

Below is the sub- routine thats causing me problems. I know there are a lot of things I can to to make this shorter, but I'm fairly new to perl and need to get this done quick.

sub error_checking {
for($i=1; $i <= $num_checks; $i++)
{
print "************************************************* **************\n";
print "* Worcester Youth Center Check # $i\n";
print "* 27 Chandler St.\n";
print "* Worcester, Ma 01609\n";
print "* Date $date[]\n";
print "*\n";
print "* Pay to: $pay_to[i] \$$amount_num[i]\n";
print "*\n";
print "* Note: $note[i]\n";
print "************************************************* **************\n";
if ($i%2 == 0)
{
print "Are these checks correct? (y/n) ";
chomp ($yesno = <STDIN>);
if ($yesno eq "n") {
&edit;}
}


}
if ($i%2){
print "Are these checks correct? (y/n) ";
chomp ($yesno = <STDIN>);
if ($yesno eq "n") {
&edit;}}
}

[bobcat]

Not a Perl programmer. Where is num_checks initialized? Is it a global that has a value >= 1? If it is not and it has a value of 0, you will never get into the loop.

Since i == 1 you will never loop: i <= num_checks :: 1 <= 0.

[emcron]

$num_checks will always be >=1, if it wasn't the program wouldn't reach that subroutine.

[qball]

a conditional (if) inside a loop (for) will only cause problems (fingers crossed as people do stupid stuff) if you mess with the incrementing loop var, in this case $i.

Now, you a using $i for each loop.

replace:

"for($i=1; $i <= $num_checks; $i++) "

wif:

"for($uniquename=1; $uniquename <= $num_checks; $uniquename++)"


You may also have an issue with $num_checks.

Keep your variables in scope, I think you can figure out which loop is the problem.